Expiration now based on Current Key Create Time instead of Previous key create time #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecret Create Time
JaCoCo code coverage report - scala:2.12.17
|
dk1844
approved these changes
Jan 21, 2025
Collaborator
dk1844
left a comment
dk1844
left a comment
There was a problem hiding this comment.
Haha, I did not realize this issue.
Makes sense like this (just read the code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Minor BugFix for Key Phase expiry being based on the previous keys creation time. This is incorrect as this reflects the previous rotation time and therefore the key will always be expired.
We need to base the expiry time on the creation time of the current key as that's the latest rotation time.
closes #114