117 delay option for new set of key signing #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo code coverage report - scala:2.12.17
|
dk1844
reviewed
Feb 6, 2025
Collaborator
dk1844
left a comment
dk1844
left a comment
There was a problem hiding this comment.
Most of the comments are details, but adding tests to the AwsSecretsManagerKeyConfig seem necessary
api/src/main/scala/za/co/absa/loginsvc/rest/config/jwt/AwsSecretsManagerKeyConfig.scala
Outdated
Show resolved
Hide resolved
api/src/main/scala/za/co/absa/loginsvc/rest/config/jwt/AwsSecretsManagerKeyConfig.scala
Outdated
Show resolved
Hide resolved
api/src/main/scala/za/co/absa/loginsvc/rest/config/jwt/AwsSecretsManagerKeyConfig.scala
Outdated
Show resolved
Hide resolved
api/src/test/scala/za/co/absa/loginsvc/rest/service/jwt/JWTServiceTest.scala
Outdated
Show resolved
Hide resolved
dk1844
reviewed
Feb 12, 2025
dk1844
reviewed
Feb 12, 2025
Collaborator
dk1844
left a comment
dk1844
left a comment
There was a problem hiding this comment.
Just some details (code quality/readability improvements)
api/src/test/scala/za/co/absa/loginsvc/rest/config/jwt/AwsSecretsManagerKeyConfigTest.scala
Outdated
Show resolved
Hide resolved
api/src/main/scala/za/co/absa/loginsvc/utils/AwsSecretsUtils.scala
Outdated
Show resolved
Hide resolved
api/src/main/scala/za/co/absa/loginsvc/rest/config/jwt/AwsSecretsManagerKeyConfig.scala
Outdated
Show resolved
Hide resolved
dk1844
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
closes #117