-
Notifications
You must be signed in to change notification settings - Fork 1
#133: on ldap connection error, communicate 504 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JaCoCo code coverage report - scala:2.12.17
|
api/src/main/scala/za/co/absa/loginsvc/rest/service/jwt/JWTService.scala
Show resolved
Hide resolved
dk1844
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TheLydonKing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested on my side
dk1844
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces different non-ok response to users besides the original 401, on LDAP connection errors.
In this particular situation, failing to connect to LDAP should give users 504.
Example run with mangled config to induce the error:
POST http://localhost:9090/token/generate?groups-prefixes=with e.g.
Authorization: Basic bXl1c2VybmFtZTp3aGF0LWFyZS15b3UtbG9va2luZy1mb3ItaGVyZT8=->
504@TheLydonKing
Release notes:
Closes #133