Skip to content

Conversation

@dk1844
Copy link
Collaborator

@dk1844 dk1844 commented Oct 22, 2025

Originally with /token/generate?group-prefixes=prefix1,PREFIX2,PREFiX3, the prefixes were always case-sensitive. This proved to be less than ideal.

Newly, there is a optional param case-sensitive=true|false (default: false if not given) that governs how group prefixes filtering is done.

Release notes:

  • Previously existing /token/generate?group-prefixes=prefixHere is no longer case-sensitive by default. One may add &case-sensitive=true to bring back previous behavior.

Closes #146

Migration notes:

Login service v1.6.0 and older's /token/generate?group-prefixes=prefixesHere equivalent will now be /token/generate?group-prefixes=prefixesHere&case-sensitive=true

@dk1844 dk1844 requested a review from jakipatryk as a code owner October 22, 2025 12:29
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Report: Report: api - scala:2.12.17

Metric (instruction) Coverage Threshold Status
Overall 68.77% 43.0%
Changed Files 90.71% 70.0%
File Path Coverage Threshold Status
TokenController.scala 81.42% 0.0%
User.scala 100.0% 0.0%

Copy link
Collaborator

@jakipatryk jakipatryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just these "`case-sensitive`" backquote-based arguments name looks weird and I personally prefer to not use them unless a Java library is used which forces us to have them, for example to adhere to an interface.

@dk1844 dk1844 merged commit fc8ac45 into master Oct 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LS] Introduces /token/generate?group-prefixes case-sensitivity control

3 participants