Merged
Conversation
salamonpavel
requested review from
TebaleloS,
Zejnilovic,
benedeki,
dk1844 and
lsulak
as code owners
JaCoCo code coverage report - scala:2.11 - spark:2.4
|
JaCoCo code coverage report - scala:2.12 - spark:3.3
|
lsulak
reviewed
Oct 3, 2025
| lazy val spark33 = "3.3.2" | ||
| lazy val spark32 = "3.2.4" | ||
| lazy val spark33 = "3.3.2" | ||
| lazy val spark35 = "3.5.5" |
Collaborator
There was a problem hiding this comment.
still, don't we want to build it also for Spark 3.4 ? Since it's OSS used across many projects
Collaborator
Author
There was a problem hiding this comment.
I don't think it's necessary. And by that logic I would have to add few additional versions (both lower and higher).
Collaborator
There was a problem hiding this comment.
so what happens if someone is using Spark 3.4 in their project? What would happen if we are using it on some of our major projects? Isn't it the same scenario as for this 3.5.x?
Collaborator
Author
There was a problem hiding this comment.
it's been added, hope it's alright finally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Spark 3.4.x and 3.5.x