Conversation
salamonpavel
requested review from
Zejnilovic,
benedeki,
dk1844 and
lsulak
as code owners
JaCoCo code coverage report - scala:2.11 - spark:2.4
|
JaCoCo code coverage report - scala:2.12 - spark:3.3
|
project/SparkVersionAxis.scala
Outdated
|
|
||
| override val directorySuffix = if (sparkVersion.startsWith("2")) s"-spark${sparkVersionMinor}" else "-spark3" | ||
|
|
||
| override val idSuffix: String = |
There was a problem hiding this comment.
please let's try to document these decisions - why it's needed. It's impossible to know from the code itself and these are bigger changes to the build
There was a problem hiding this comment.
yup, added some comments
benedeki
left a comment
benedeki
left a comment
There was a problem hiding this comment.
I would just return to the previous version, only extend the version list and have one common dir for SPark 3.x
|
Also no connected issue again. 😔 |
I don't understand. Please explain in more detail because I cannot simply use the previous version, it wouldn't work. The changes I introduced were necessary, I wouldn't have introduced them otherwise. |
Added the related bug ticket reference. |
What I would rather suggest is to have also only one folder for Spark2 versions, that would simplify the build definition. |
|
Discussions above resolved on call. |
benedeki
left a comment
benedeki
left a comment
There was a problem hiding this comment.
Seems to work, that's the goal.
| import sbt.VirtualAxis._ | ||
| import sbt.internal.ProjectMatrix | ||
| import sbtprojectmatrix.ProjectMatrixKeys._ | ||
| import Dependencies._ |
There was a problem hiding this comment.
This is duplicity, it's already here above
3 participants
Fixes issues resulting in producing empty jars.
Closes #124