Only send alert when feed is enabled in configuration.#3
Open
iTeV wants to merge 1 commit intoAbuseIO:masterfrom
Open
Only send alert when feed is enabled in configuration.#3iTeV wants to merge 1 commit intoAbuseIO:masterfrom
iTeV wants to merge 1 commit intoAbuseIO:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, AbuseIO sends alerts out when a disabled feed did not return any incidents, which is "expected", since it is disabled in the configuration. This commit changes the logic in that, so AbuseIO does not send out any alerts when a feed is not enabled.
Now, I dont know whether this is the perfect "solution" for this, but it worked quite well in my configuration. So might aswell give this PR a shot :)
Let me know if I need to make some changes (or do 'em yourself, also possible :>)