-
Notifications
You must be signed in to change notification settings - Fork 406
Type description improvements #2176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type description improvements #2176
Conversation
|
This PR includes and replaces #2107, which can be closed if this PR is approved. |
source/JsMaterialX/JsMaterialXGenGlsl/JsGlslShaderGenerator.cpp
Outdated
Show resolved
Hide resolved
source/JsMaterialX/JsMaterialXGenEssl/JsEsslShaderGenerator.cpp
Outdated
Show resolved
Hide resolved
ld-kerley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me - thanks for getting this all squared away!
I left a small question below - but happy to defer to whatever you think.
Signed-off-by: Jonathan Stone <[email protected]>
Signed-off-by: Jonathan Stone <[email protected]>
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this excellent work, @niklasharrysson, and I believe this is ready to merge once all tests pass.
0b40d67
into
AcademySoftwareFoundation:main
This change list is an overhaul of the type system in shader generation.
Improvements include:
Co-work with @ld-kerley