-
Notifications
You must be signed in to change notification settings - Fork 407
Improvements to StandardNodes tables #2728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to StandardNodes tables #2728
Conversation
Building upon the work in the new `comparenodes.py` script, this changelist makes several improvements to the tables in the StandardNodes specification, bringing the specification into closer alignment with the data libraries. Using the output of `comparenodes.py` as a measure, this changelist reduces the number of differences between the StandardNodes specification and data libraries from 122 to 46. Additionally, this changelist enables GitHub CI for changelists containing only edits to Markdown files, so that `comparenodes.py` is run on changes that contain only specification updates.
|
For reference, here is the new output of |
| |`falloff` |Falloff width used to blend neighboring tiles at their edges; larger values produce smoother blends|float |0.5 | | ||
| |`falloffcontrast` |Contrast applied to the falloff blending to sharpen (values >1) or soften (values <1) transitions |float |0.5 | | ||
| |`lumacoeffs` |The luma coefficients of the current working color space |color3 |0.2722287, 0.6740818, 0.0536895| | ||
| |`out` |Output: the sampled texture value |Same as `default`|__zero__ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: For consistency with the other nodes would it make sense to have the output define the data type, and let default derive from this? That is, just flip the relation here so default says Same as 'out'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, and I've made this change across the texture nodes for consistency.
niklasharrysson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, and I only had a minor comment above.
d6ecee3
into
AcademySoftwareFoundation:main
Building upon the work in the new
comparenodedefs.pyscript, this changelist makes several improvements to the tables in the StandardNodes specification, bringing the specification into closer alignment with the data libraries.Using the output of
comparenodedefs.pyas a measure, this changelist reduces the number of differences between the StandardNodes specification and data libraries from 122 to 46.Additionally, this changelist enables GitHub CI for changelists containing only edits to Markdown files, so that
comparenodedefs.pyis run on changes that contain only specification updates.