ci: Skip JavaScript job on forks#2757
Open
ppenenko wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Open
ci: Skip JavaScript job on forks#2757ppenenko wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
ppenenko wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Member
|
This is a very reasonable proposal, @ppenenko, though we'll need to provide an alternative mechanism for developers to request a deployment of the MaterialX Web Viewer in their MaterialX fork. Maybe we could link this to extended CI builds, so that a manual trigger of the main MaterialX workflow would include a deployment of the MaterialX Web Viewer? Other ideas here are welcome, and the goal is to provide developers with easy access to testing their proposed changes to the MaterialX Web Viewer, without impacting teams that might be restricted from enabling web deployment for all MaterialX builds. |
Contributor
Author
|
Good point @jstone-lucasfilm but I'm not sure if extended builds would succeed for most forks. Let me dig deeper into the failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JavaScript job in the main CI workflow attempts to deploy to GitHub Pages, which fails on forks since they don't have the same Pages configuration as upstream.
E.g. https://github.com/autodesk-forks/MaterialX/actions/runs/21080475833/
This adds a condition to skip the JavaScript job on forks, matching the existing pattern used by the
sdistandwheelsjobs.