Skip to content

Add multioutput type check in getShaderNodes #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstone-lucasfilm merged 4 commits into from
Jan 30, 2026
Merged

Add multioutput type check in getShaderNodes #2760

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26605b6
Add check for multioutput type nodes in getShaderNodes type matching
xipaja Jan 28, 2026
c2d74d9
Merge branch 'multi-shader-output-bug' of https://github.com/xipaja/M…
xipaja Jan 28, 2026
1739a8a
Merge branch 'main' into multi-shader-output-bug
xipaja Jan 29, 2026
6e7adc6
Merge branch 'main' into multi-shader-output-bug
jstone-lucasfilm Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion source/MaterialXCore/Material.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,19 @@ vector<NodePtr> getShaderNodes(NodePtr materialNode, const string& nodeType, con
NodePtr shaderNode = input->getConnectedNode();
if (shaderNode && !shaderNodeSet.count(shaderNode))
{
if (!nodeType.empty() && shaderNode->getType() != nodeType)
bool inputMatchesOutputType = !nodeType.empty() && shaderNode->getType() == nodeType;

if (shaderNode->isMultiOutputType())
{
const vector<OutputPtr>& activeOutputs = shaderNode->getActiveOutputs();
bool multiOutputMatches = std::any_of(activeOutputs.begin(), activeOutputs.end(), [&nodeType](const OutputPtr& output)
{
return output->getType() == nodeType;
});
inputMatchesOutputType = multiOutputMatches || inputMatchesOutputType;
}

if (!inputMatchesOutputType)
{
continue;
}
Expand Down