Fix UiEdge node order in Graph Editor#2770
Merged
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom Feb 13, 2026
Merged
Fix UiEdge node order in Graph Editor#2770jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
This changelist fixes a swapped argument order in the `UiEdge` constructor, where the upstream and downstream nodes were inverted relative to the usage of the constructor in the codebase. Callers of the `UiEdge` constructor have been using the following convention, as seen in the `Graph::createEdge` method: ``` UiEdge newEdge = UiEdge(upNode, downNode, connectingInput); ``` But the constructor itself has been expecting arguments in the reverse order, as seen here: ``` UiEdge(UiNodePtr uiDown, UiNodePtr uiUp, mx::InputPtr input) ``` This changelist updates the arguments of the `UiEdge` constructor and all dependent code, making the semantics of `UiEdge::getUp` and `UiEdge::getDown` consistent across the Graph Editor codebase.
lfl-eholthouser
approved these changes
Feb 13, 2026
Contributor
lfl-eholthouser
left a comment
lfl-eholthouser
left a comment
There was a problem hiding this comment.
Looks great, thanks @jstone-lucasfilm!
jstone-lucasfilm
merged commit ad71ce0
into
AcademySoftwareFoundation:main
33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist fixes a swapped argument order in the
UiEdgeconstructor, where the upstream and downstream nodes were inverted relative to the usage of the constructor in the codebase.Callers of the
UiEdgeconstructor have been using the following convention, as seen in theGraph::createEdgemethod:But the constructor itself has been expecting arguments in the reverse order, as seen here:
This changelist updates the arguments of the
UiEdgeconstructor and all dependent code, making the semantics ofUiEdge::getUpandUiEdge::getDownconsistent across the Graph Editor codebase.