[cueman] Add unit tests and validation for frame operations #1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkxthyl
requested review from
DiegoTavares,
lithorus and
ramonfigueiredo
as code owners
Collaborator
|
Hi @kkxthyl , Please fix the Lint Python issues. Thanks! |
kkxthyl
force-pushed
the
test-frame-operations
branch
from
69c3ed4 to
d546995
Compare
kkxthyl
force-pushed
the
test-frame-operations
branch
from
d546995 to
8c91e9b
Compare
- Fix typo in test method name: from `test_done_fundtionality` to `test_done_functionality` - Correct layer parameter type from string to list in 7 tests to match argparse nargs="+" behavior - Update assertions to expect list values instead of strings for consistency with actual command-line argument parsing These changes ensure tests accurately reflect how the `-layer` argument is parsed and passed through the application.
Document validation rules for frame operations added in recent changes: - Stagger increment: Must be a positive integer (rejects 0, negative, non-numeric) - Reorder position: Must be FIRST, LAST, or REVERSE - Frame ranges: Must be numeric with start < = end Updated files: - docs/_docs/reference/tools/cueman.md: Added validation notes and troubleshooting examples for invalid inputs - docs/_docs/tutorials/cueman-tutorial.md: Added validation notes in Frame Manipulation section and error examples - cueman/cueman_tutorial.md: Added validation notes for stagger and reorder - cueman/README.md: Updated inline comments to reflect requirements Users will now see clear guidance on valid inputs and understand error messages when validation fails.
…enCue into test-frame-operations
ramonfigueiredo
changed the title
ramonfigueiredo
changed the title
Collaborator
ramonfigueiredo
approved these changes
Sep 30, 2025
ramonfigueiredo
merged commit cfc32ef
into
AcademySoftwareFoundation:master
20 checks passed
Collaborator
|
Merged! Great job, @kkxthyl ! |
Collaborator
====================================================================== test session starts =======================================================================
cachedir: .pytest_cache
configfile: pyproject.toml
collected 24 items
cueman/tests/test_frame_operations.py::TestFrameOperations::test_done_confirmation_prompt PASSED [ 4%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_done_functionality PASSED [ 8%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_eatFrames_with_dead_state_filter PASSED [ 12%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_eatFrames_with_running_state_filter PASSED [ 16%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_eatFrames_with_succeeded_state_filter PASSED [ 20%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_eatFrames_with_valid_layer PASSED [ 25%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_eatFrames_with_waiting_state_filter PASSED [ 29%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_eat_confirmation_prompt PASSED [ 33%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_invalid_nonnumeric_range_inputs PASSED [ 37%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_invalid_reverse_range_inputs PASSED [ 41%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_killFrames_with_valid_layer PASSED [ 45%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_kill_confirmation_prompt PASSED [ 50%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_reorder_first_operation PASSED [ 54%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_reorder_invalid_operation PASSED [ 58%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_reorder_last_operation PASSED [ 62%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_reorder_reverse_operation PASSED [ 66%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_retryFrames_with_valid_layer PASSED [ 70%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_retry_confirmation_prompt PASSED [ 75%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_stagger_increments PASSED [ 79%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_stagger_negative_increments PASSED [ 83%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_stagger_nonnumeric_increments PASSED [ 87%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_stagger_zero_increments PASSED [ 91%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_valid_range_inputs PASSED [ 95%]
cueman/tests/test_frame_operations.py::TestFrameOperations::test_valid_single_range_inputs PASSED [100%]
======================================================================= 24 passed in 0.54s ======================================================================= |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Summarize your change.
Summary:
Add comprehensive unit tests for frame-specific operations and implement input validation for stagger, reorder, and frame range operations. Updated documentation to reflect new validation requirements.
Changes:
cueman/tests/test_frame_operations.py)Created comprehensive test suite covering:
cueman/cueman/main.py)Added validation to ensure:
Updated documentation across multiple files:
docs/_docs/reference/tools/cueman.md: Added validation notes and troubleshooting examples for invalid inputsdocs/_docs/tutorials/cueman-tutorial.md: Added validation notes in Frame Manipulation section and error examplescueman/cueman_tutorial.md: Added validation notes for stagger and reordercueman/README.md: Updated inline comments to reflect requirementstest_done_fundtionalitytotest_done_functionalitynargs="+"behaviorCo-authored-by: Kathy Lee [email protected]
Co-authored-by: Ramon Figueiredo [email protected]