[cuegui] Fix layer tags validation to allow dashes and underscores #2120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The TagsWidget.get_tags() method used isalnum() to filter tags, which rejected any tag containing dashes (e.g., "test-layer-tag"). This caused the layer properties dialog to fail with "no tag selected" error. - Replace isalnum() with a new _is_valid_tag() method that uses regex to allow alphanumeric characters, dashes, and underscores in tag names.
Collaborator
Author
|
ramonfigueiredo
requested review from
DiegoTavares and
lithorus
as code owners
Collaborator
Author
|
@DiegoTavares / @lithorus |
DiegoTavares
approved these changes
Dec 19, 2025
ramonfigueiredo
merged commit ce61412
into
AcademySoftwareFoundation:master
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Summarize your change.
The TagsWidget.get_tags() method used isalnum() to filter tags, which rejected any tag containing dashes (e.g., "test-layer-tag"). This caused the layer properties dialog to fail with "no tag selected" error.
Replace isalnum() with a new _is_valid_tag() method that uses regex to allow alphanumeric characters, dashes, and underscores in tag names.