fix: some LoggedTimer instances lacked a variable name #4571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing those timers to fail because without an actual variable, there was no RAII scope. Found by Sonar warnings. Signed-off-by: Larry Gritz <[email protected]>
Signed-off-by: Larry Gritz <[email protected]>
jessey-git
approved these changes
Dec 27, 2024
Contributor
jessey-git
left a comment
jessey-git
left a comment
There was a problem hiding this comment.
Looks like they're all taken care of now.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 28, 2024
…reFoundation#4571) It was syntactically correct, but without an actual variable, there was no RAII scope and so it destructs immediately, causing the timers to capture 0 time. Found by Sonar warnings. --------- Signed-off-by: Larry Gritz <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
…reFoundation#4571) It was syntactically correct, but without an actual variable, there was no RAII scope and so it destructs immediately, causing the timers to capture 0 time. Found by Sonar warnings. --------- Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was syntactically correct, but without an actual variable, there was no RAII scope and so it destructs immediately, causing the timers to capture 0 time.
Found by Sonar warnings.