cleanup: no longer need OIIO_INLINE_CONSTEXPR macro #4607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our minimum C++ version allows `inline constexpr`, just use it. Signed-off-by: Larry Gritz <[email protected]>
mugulmd
reviewed
Jan 30, 2025
| #endif | ||
|
|
||
| // DEPRECATED(3.1): use C++17 inline constexpr | ||
| #define OIIO_INLINE_CONSTEXPR inline constexpr |
Contributor
There was a problem hiding this comment.
Do we really need to keep this macro ? From what I can see you've updated all the OIIO_INLINE_CONSTEXPR in the code base, so maybe we can just get rid of it, this way we have one less macro :)
Collaborator
Author
There was a problem hiding this comment.
It's in a public header file, we can't break downstream source compatibility, even if it's something we don't use internally any longer.
Contributor
There was a problem hiding this comment.
Ah you're right, good point !
mugulmd
approved these changes
Feb 1, 2025
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
…oundation#4607) Our minimum C++ version allows `inline constexpr`, just use it. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
zachlewis
pushed a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Sep 1, 2025
…oundation#4607) Our minimum C++ version allows `inline constexpr`, just use it. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our minimum C++ version allows
inline constexpr, just use it.