fix(ImageBuf): IB::pixeltype() did not always return the right value #4614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of IB::pixeltype() was: - Make sure at least the spec had been read (lazy read). - If there are "local pixels", return the pixel type from the spec, otherwise return the cache pixel type. But there is a flaw in this logic: If only the metadata has been read but not the pixels, the local pixels might not be allocated yet, but also there is not a cache and no cached pixel type, so pixeltype() will return UNKNOWN even though we do already know what type of pixels will be stored when they are eventually read. The correct logic is: - Make sure at least the spec had been read (lazy read). - If it's a cached image, return the cache pixel type, otherwise return the pixel type from the spec (which will be correct because we definitely have read the spec at this point). Also, for legit cached images, ensure that cachedpixeltype is set upon read_spec() and doesn't have to wait for a full read(). Signed-off-by: Larry Gritz <[email protected]>
|
This fixes the issue I reported on Slack. Cheers! |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Feb 3, 2025
…cademySoftwareFoundation#4614) The implementation of IB::pixeltype() was: - Make sure at least the spec had been read (lazy read). - If there are "local pixels", return the pixel type from the spec, otherwise return the cache pixel type. But there is a flaw in this logic: If only the metadata has been read but not the pixels, the local pixels might not be allocated yet, but also there is not a cache and no cached pixel type, so pixeltype() will return UNKNOWN even though we do already know what type of pixels will be stored when they are eventually read. The correct logic is: - Make sure at least the spec had been read (lazy read). - If it's a cached image, return the cache pixel type, otherwise return the pixel type from the spec (which will be correct because we definitely have read the spec at this point). Also, for legit cached images, ensure that cachedpixeltype is set upon read_spec() and doesn't have to wait for a full read(). Signed-off-by: Larry Gritz <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 17, 2025
…cademySoftwareFoundation#4614) The implementation of IB::pixeltype() was: - Make sure at least the spec had been read (lazy read). - If there are "local pixels", return the pixel type from the spec, otherwise return the cache pixel type. But there is a flaw in this logic: If only the metadata has been read but not the pixels, the local pixels might not be allocated yet, but also there is not a cache and no cached pixel type, so pixeltype() will return UNKNOWN even though we do already know what type of pixels will be stored when they are eventually read. The correct logic is: - Make sure at least the spec had been read (lazy read). - If it's a cached image, return the cache pixel type, otherwise return the pixel type from the spec (which will be correct because we definitely have read the spec at this point). Also, for legit cached images, ensure that cachedpixeltype is set upon read_spec() and doesn't have to wait for a full read(). Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
…cademySoftwareFoundation#4614) The implementation of IB::pixeltype() was: - Make sure at least the spec had been read (lazy read). - If there are "local pixels", return the pixel type from the spec, otherwise return the cache pixel type. But there is a flaw in this logic: If only the metadata has been read but not the pixels, the local pixels might not be allocated yet, but also there is not a cache and no cached pixel type, so pixeltype() will return UNKNOWN even though we do already know what type of pixels will be stored when they are eventually read. The correct logic is: - Make sure at least the spec had been read (lazy read). - If it's a cached image, return the cache pixel type, otherwise return the pixel type from the spec (which will be correct because we definitely have read the spec at this point). Also, for legit cached images, ensure that cachedpixeltype is set upon read_spec() and doesn't have to wait for a full read(). Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of IB::pixeltype() was:
But there is a flaw in this logic: If only the metadata has been read but not the pixels, the local pixels might not be allocated yet, but also there is not a cache and no cached pixel type, so pixeltype() will return UNKNOWN even though we do already know what type of pixels will be stored when they are eventually read.
The correct logic is:
Also, for legit cached images, ensure that cachedpixeltype is set upon read_spec() and doesn't have to wait for a full read().