build: fix recently broken rpath to restore python wheel building #4633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
added
bug
zachlewis
approved these changes
Feb 12, 2025
lgritz
force-pushed
the
lg-wheel-rpath
branch
from
ff6e4a6 to
96d40b6
Compare
Also, make the wheel workflow work on pushes when the branch name containt the substrings "python" or "wheel", and when any of the cmake build files in src/cmake (which control building of dependencies, among other things), even if none of the python bindings themselves are touched. This means that if you suspect your work might cause a wheel to break even though you're not modifying the python bindings directly, you can ensure that the wheel workflow will run on CI simply by naming your branch to contain one of those words. Signed-off-by: Larry Gritz <[email protected]>
lgritz
force-pushed
the
lg-wheel-rpath
branch
from
96d40b6 to
be8524e
Compare
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Feb 12, 2025
…ademySoftwareFoundation#4633) Also, make the wheel workflow work on pushes when the branch name contains the substring "python" or "wheel", and when any of the cmake build files in src/cmake (which control building of dependencies, among other things), even if none of the python bindings themselves are touched. This means that if you suspect your work might cause a wheel to break even though you're not modifying the python bindings directly, you can ensure that the wheel workflow will run on CI simply by naming your branch to contain one of those words. Signed-off-by: Larry Gritz <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 17, 2025
…ademySoftwareFoundation#4633) Also, make the wheel workflow work on pushes when the branch name contains the substring "python" or "wheel", and when any of the cmake build files in src/cmake (which control building of dependencies, among other things), even if none of the python bindings themselves are touched. This means that if you suspect your work might cause a wheel to break even though you're not modifying the python bindings directly, you can ensure that the wheel workflow will run on CI simply by naming your branch to contain one of those words. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
…ademySoftwareFoundation#4633) Also, make the wheel workflow work on pushes when the branch name contains the substring "python" or "wheel", and when any of the cmake build files in src/cmake (which control building of dependencies, among other things), even if none of the python bindings themselves are touched. This means that if you suspect your work might cause a wheel to break even though you're not modifying the python bindings directly, you can ensure that the wheel workflow will run on CI simply by naming your branch to contain one of those words. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, make the wheel workflow work on pushes when the branch name
contains the substring "python" or "wheel", and when any of the cmake
build files in src/cmake (which control building of dependencies,
among other things), even if none of the python bindings themselves
are touched. This means that if you suspect your work might cause a
wheel to break even though you're not modifying the python bindings
directly, you can ensure that the wheel workflow will run on CI simply
by naming your branch to contain one of those words.