fix(oiiotool): Ignore empty subimage(s) when calculating non-zero region #4909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes AcademySoftwareFoundation#4799 When trimming an image that contains an empty subimage, the resulting ROI unexpectedly included the top-left pixel even if zero in all subimages. To avoid this, empty ROIs are ignored when computing the overall non-zero region. If all subimages are empty, the first subimage ROI is used and doctored to be 1 pixel. Two tests have been added to the oiiotool testsuite: - 1 to check the trimming of an empty image - 1 to check the trimming of a non-empty image with an empty subimage Signed-off-by: Carine Touraille <[email protected]>
|
|
lgritz
approved these changes
Sep 27, 2025
Collaborator
lgritz
left a comment
lgritz
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 27, 2025
…ion (AcademySoftwareFoundation#4909) Fixes AcademySoftwareFoundation#4799 When trimming an image that contains an empty subimage, the resulting ROI unexpectedly included the top-left pixel even if zero in all subimages. To avoid this, empty ROIs are ignored when computing the overall non-zero region. If all subimages are empty, the first subimage ROI is used and doctored to be 1 pixel. Two tests have been added to the oiiotool testsuite: - 1 to check the trimming of an empty image - 1 to check the trimming of a non-empty image with an empty subimage Signed-off-by: Carine Touraille <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4799
Description
When trimming an image that contains an empty subimage, the resulting ROI unexpectedly included the top-left pixel even if zero in all subimages.
To avoid this, empty ROIs are ignored when computing the overall non-zero region.
If all subimages are empty, the first subimage ROI is used and doctored to be 1 pixel.
Tests
Two tests have been added to the oiiotool testsuite:
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.