-
Notifications
You must be signed in to change notification settings - Fork 652
cmake script to auto download and install the openjpeg dependency #4911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake script to auto download and install the openjpeg dependency #4911
Conversation
|
I think this is correct, but in ci.yml, in the "all local builds" job, you'll want to remove the setting of env variable OPENJPEG_VERSION=v2.5.4 because that will trigger the external script build_OpenJPEG.bash before the build. You don't want that, in this case you want to be sure you're forcing the autobuild one. |
80dac5b to
d41f053
Compare
Signed-off-by: grdanny <[email protected]>
76fd0cb to
71e5199
Compare
Signed-off-by: Larry Gritz <[email protected]>
|
I pushed some fixes to the OpenJPEG build methodology. It was all about getting correct static libraries built and recognized. |
|
I see, so if I'm running the bash script the does the OpenJpeg build and install I end up with these files: So basically we are telling the OpenImageIO build to prefer the "libopenjp2.a"? Thanks for the help with this. |
grdanny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me now if it looks good to you btw. Thanks again.
|
Aha, thanks for reminding me about the bash script. I need to adjust that, too. |
… libs. Signed-off-by: Larry Gritz <[email protected]>
|
I pushed one more amendment, to build_OpenJPEG.bash:
That's for the bash script. The cmake auto-builder already does this (in my prior patch) and should default to the static library. |
lgritz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to fully work now
|
Wait, I think I need one more adjustment. Stay tuned. |
Signed-off-by: Larry Gritz <[email protected]>
lgritz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it all works now
|
Thanks for helping me take this to the finish line. |
…cy (AcademySoftwareFoundation#4911) sub task of : AcademySoftwareFoundation#4387 for sep 2025 dev days. Adding a autobuild cmake file for OpenJPEG. Includes some changes to recognize and use static OpenJPEG if available. --------- Signed-off-by: grdanny <[email protected]> Signed-off-by: Larry Gritz <[email protected]> Co-authored-by: Larry Gritz <[email protected]>
Description
sub task of : #4387
for sep 2025 dev days.
Adding a autobuild cmake file for openjpeg.
Matching the latest version like in the yet unmerged:
#4910
Tests
I built it locally - I can see it's downloading the files from github and building them.
I can run the tests.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.