ci: Try to avoid ffmpeg install failures #4936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small portion of time -- maybe 10%, just enough for many CI workflow runs to have a single job fail -- our attempt to `dnf install ffmpeg` fails. I thought maybe it was an intermittent, transient failure. But looping to try multiple times with delays in between does not help. A job that fails once either succeeds initially or fails over and over. I'm now leaning toward the belief that rather than a transient failures, there are just a subset of GHA runners that will always fail, and the semi-random nature of our job failures is just random luck of the draw in runner selection. Anyway, so I'm not going to merge the try-in-a-loop approach. Instead, this PR just makes ffmpeg an optional dependency, so the failures to get the dependency won't fail the OIIO build and therefore the CI. It seems like most of the time we really do get the dependency, but I'm out of better ideas at the moment. Signed-off-by: Larry Gritz <[email protected]>
Collaborator
Author
|
I am going to preemptively merge this because it's a CI only change (doesn't change the code or anyone else's builds), and without it, nearly all other PRs are spuriously failing CI. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 19, 2025
) A small portion of time -- maybe 10%, just enough for many CI workflow runs to have a single job fail -- our attempt to `dnf install ffmpeg` fails. I thought maybe it was an intermittent, transient failure. But looping to try multiple times with delays in between does not help. A job that fails once either succeeds initially or fails over and over. I'm now leaning toward the belief that rather than a transient failures, there are just a subset of GHA runners that will always fail, and the semi-random nature of our job failures is just random luck of the draw in runner selection. Anyway, so I'm not going to merge the try-in-a-loop approach. Instead, this PR just makes ffmpeg an optional dependency, so the failures to get the dependency won't fail the OIIO build and therefore the CI. It seems like most of the time we really do get the dependency, but I'm out of better ideas at the moment. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small portion of time -- maybe 10%, just enough for many CI workflow runs to have a single job fail -- our attempt to
dnf install ffmpegfails.I thought maybe it was an intermittent, transient failure. But looping to try multiple times with delays in between does not help. A job that fails once either succeeds initially or fails over and over. I'm now leaning toward the belief that rather than a transient failures, there are just a subset of GHA runners that will always fail, and the semi-random nature of our job failures is just random luck of the draw in runner selection.
Anyway, so I'm not going to merge the try-in-a-loop approach. Instead, this PR just makes ffmpeg an optional dependency, so the failures to get the dependency won't fail the OIIO build and therefore the CI. It seems like most of the time we really do get the dependency, but I'm out of better ideas at the moment.