build: Disable LERC in libTIFF local build script #4957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, when building OIIO using
OpenImageIO_BUILD_LOCAL_DEPS=allcmake option, I noticed a reference tolercthat fails during the linker stage, when compiling the simd tests:lercis an image compression library from ESRI: https://github.com/Esri/lercA deeper dive of this reference to lerc shows that it is referred in
libtiff.libtiff, however, did not seem to correctly export this dependency to OIIO when being built locally.If someone was building OIIO with a system-installed
libtiff, this error is unlikely to happen.By disabling
lercinlibTiff, the local build scripts (OpenImageIO_BUILD_LOCAL_DEPS=all) runs without a problem.Tests
Tested build OIIO with
OpenImageIO_BUILD_LOCAL_DEPS=allwith this patch and was successful in finishing the build.Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.