Skip to content

Build all python package dependencies #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rogernelson wants to merge 1 commit into from
Closed

Build all python package dependencies #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions cmake/dependencies/python3.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,13 @@ SET(RV_DEPS_PYTHON_VERSION_SHORT
)

# This version is used for generating src/build/requirements.txt from requirements.txt.in template
# All platforms install OpenTimelineIO from git to ensure consistent source builds.
SET(_opentimelineio_version
"${RV_DEPS_OTIO_VERSION}"
)

SET(_pyside_version
"${RV_DEPS_PYSIDE_VERSION}"
)
# Construct the full git URL for pip to use in requirements.txt
# Using this avoids @ symbol conflicts in CONFIGURE_FILE
SET(_opentimelineio_pip_url
"git+https://github.com/AcademySoftwareFoundation/OpenTimelineIO@v${_opentimelineio_version}#egg=OpenTimelineIO"
)

SET(_python3_download_url
"https://github.com/python/cpython/archive/refs/tags/v${_python3_version}.zip"
Expand Down Expand Up @@ -79,9 +73,6 @@ SET(_build_dir
${RV_DEPS_BASE_DIR}/${_python3_target}/build
)

# Note: OpenTimelineIO is now installed via requirements.txt from git URL for all platforms.
# This ensures consistent source builds across Windows, Mac, and Linux.

FETCHCONTENT_DECLARE(
${_pyside_target}
URL ${_pyside_archive_url}
Expand Down Expand Up @@ -283,12 +274,13 @@ ELSE()
SET(_otio_debug_env "")
ENDIF()

# Single unified command for all platforms and build types
# Using --no-binary :all: to ensure all packages with native extensions are built from source
# against our custom Python build, preventing ABI compatibility issues.
SET(_requirements_install_command
${CMAKE_COMMAND} -E env
${_otio_debug_env}
"CMAKE_ARGS=-DPYTHON_LIBRARY=${_python3_cmake_library} -DPYTHON_INCLUDE_DIR=${_include_dir} -DPYTHON_EXECUTABLE=${_python3_executable}"
"${_python3_executable}" -m pip install --upgrade --no-cache-dir --force-reinstall -r "${_requirements_output_file}"
"${_python3_executable}" -m pip install --upgrade --no-cache-dir --force-reinstall --no-binary :all: -r "${_requirements_output_file}"
)

IF(RV_TARGET_WINDOWS)
Expand Down
3 changes: 2 additions & 1 deletion src/build/requirements.txt.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
# This file contains all the packages that will be packaged with RV. Please add the license next to the package.
# NOTE: This is a CMake template file. The actual requirements.txt is generated during CMake configuration.
# To update OpenTimelineIO version, edit _opentimelineio_version in cmake/dependencies/python3.cmake
# NOTE: Using --no-binary :all: in pip install ensures all packages are built from source against our custom Python.

pip # License: MIT License (MIT)
setuptools # License: MIT License
@_opentimelineio_pip_url@ # License: Other/Proprietary License (Modified Apache 2.0 License)
opentimelineio==@_opentimelineio_version@ # License: Other/Proprietary License (Modified Apache 2.0 License)
PyOpenGL # License: BSD License (BSD)

# MacOS only - PyOpenGL_accelerate is built from source in python3.cmake as a workaround until the fix
Expand Down
Loading