Fix clearAllSlot #1020
Merged
Fix clearAllSlot #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Éloïse Brosseau <[email protected]>
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
bernie-laberge
approved these changes
Dec 11, 2025
Contributor
bernie-laberge
left a comment
bernie-laberge
left a comment
There was a problem hiding this comment.
Exactly the same as mine !
Looks Great !
rogernelson
approved these changes
Dec 11, 2025
cedrik-fuoco-adsk
approved these changes
Dec 11, 2025
bernie-laberge
merged commit 9885e31
into
AcademySoftwareFoundation:main
9 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix clearAllSlot
Summarize your change.
Add missing
}forif(!_skipConfirmations).Describe the reason for the change.
While resolving the conflict between #1017 and #1016, the indentation of the code got changed and it resulted in a missing closing brace. Because of this issue, the following error is displayed in the console:
annotate_mode.mu, line 2210, char 41: method declaration not allowed in this context. Assertion failed: ((nparams == 0 && params == 0) || (nparams != 0 && params != 0)), function init, file Function.cpp, line 69.