SG-41208: Add softDeleted paint node property to support undo, redo and clear actions in Live Review #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
cedrik-fuoco-adsk
approved these changes
Dec 17, 2025
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
eloisebrosseau
force-pushed
the
clear-live-review
branch
from
11bb3ab to
96b7b56
Compare
eloisebrosseau
merged commit fe14d08
into
AcademySoftwareFoundation:main
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SG-41208: Add softDeleted paint node property to support undo, redo and clear actions in Live Review
Summarize your change.
A
softDeletedproperty was added for each paint node stroke to support undo, redo and clear actions for OTIO-based Live Review. This new property is following the same pattern as the newuuidproperty. These aren't known by the C++ code responsible for rendering annotations, they are simply used to help with keeping the Annotate and the Live Review package synchronized in terms of the state of each annotation. For each undo, redo and clear action, the Annotate Mode will send an internal event with the least of stroke uuids affected by the action. Thenamefield in the OTIO Paint schema was completely removed since it was decided it was actually needed since it isn't an OTIO effect.Describe the reason for the change.
The
softDeletedproperty was already added as a field in the OTIO Paint schema but it was also added as an RV node property to facilitate the interaction between the Live Review plugin that needs this information and the Annotate mode that is making the action.Describe what you have tested and on which operating system.
Drawing, undoing, redoing and clearing strokes was tested on macOS 15.6.1.
Add a list of changes, and note any that might need special attention during the review.
Note that this PR branch is based for the moment on #1021 so the changes to review are only the ones from Dec 16th.