Fix issue with runtime.build_os and runtime.build_architecture #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n nothing Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
bernie-laberge
approved these changes
Nov 13, 2024
Contributor
bernie-laberge
left a comment
bernie-laberge
left a comment
There was a problem hiding this comment.
LGTM
Thank you Cédrik !
eloisebrosseau
approved these changes
Nov 20, 2024
cedrik-fuoco-adsk
merged commit f792dd7
into
AcademySoftwareFoundation:main
9 checks passed
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 28, 2024
…mySoftwareFoundation#623) ### Fix issue with runtime.build_os and runtime.build_architecture ### Linked issues n/a ### Summarize your change. Add missing compiler definitions for MacOS and Linux. There are some unrelated changes because of the pre-commit hook. ### Describe the reason for the change. The command build_os and build_architecture were returning empty strings on Linux. ### Describe what you have tested and on which operating system. Rocky 8 Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 28, 2024
…mySoftwareFoundation#623) ### Fix issue with runtime.build_os and runtime.build_architecture ### Linked issues n/a ### Summarize your change. Add missing compiler definitions for MacOS and Linux. There are some unrelated changes because of the pre-commit hook. ### Describe the reason for the change. The command build_os and build_architecture were returning empty strings on Linux. ### Describe what you have tested and on which operating system. Rocky 8 Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 28, 2024
…mySoftwareFoundation#623) ### Fix issue with runtime.build_os and runtime.build_architecture ### Linked issues n/a ### Summarize your change. Add missing compiler definitions for MacOS and Linux. There are some unrelated changes because of the pre-commit hook. ### Describe the reason for the change. The command build_os and build_architecture were returning empty strings on Linux. ### Describe what you have tested and on which operating system. Rocky 8 Signed-off-by: Cédrik Fuoco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with runtime.build_os and runtime.build_architecture
Linked issues
n/a
Summarize your change.
Add missing compiler definitions for MacOS and Linux. There are some unrelated changes because of the pre-commit hook.
Describe the reason for the change.
The command build_os and build_architecture were returning empty strings on Linux.
Describe what you have tested and on which operating system.
Rocky 8