Enable first frame to start at 0 #625
Conversation
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
eloisebrosseau
force-pushed
the
off-by-one-frame
branch
from
34d0dc5 to
9a0fbbe
Compare
| static_cast<double>(m_avFormatContext->start_time) / static_cast<double>(AV_TIME_BASE))); | ||
| if (evStartFrameAtOne.getValue()) | ||
| { | ||
| firstFrame = max(int64_t(m_formatStartFrame), int64_t(1)); |
There was a problem hiding this comment.
Correct me if I am wrong but the m_formatStartFrame is no longer initialized right ? (with or without the new env var)
There was a problem hiding this comment.
Agreed. Is the variable still needed?
There was a problem hiding this comment.
It's not needed anymore, but I did not update the code since I'm not sure we still need the changes from this PR. This was first done to try to fix an issue with Live Review in a web to RV session that has since been fixed from the web side. I kept this PR open in the meantime, but I think it might be fine to close it and let RV have its first frame at 1 since it is now able to set it to 0 when that's the value sent by the ReviewApp without changing anything.
There was a problem hiding this comment.
Yes we could close it and we can always re-open it if we realize we need it.
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
eloisebrosseau
force-pushed
the
off-by-one-frame
branch
from
9a0fbbe to
521658f
Compare
3 participants
Enable first frame to start at 0
Summarize your change.
If there is no timecode, the first frame will be 0 or the value calculated from the
start_timefield of the AVFormatContext. The offset is also adjusted to be at least 0 to prevent it from being negative.Describe the reason for the change.
In RV, if the media has no timecode, the first frame was being set to 1 if the
start_timefield of the AVFormatContext is 0. However, this was preventing the frame to be set to 0 to match the timeline of the Review App. The offset was also being set to a negative value when the first frame was set to 0.Describe what you have tested and on which operating system.
I manually tested a few movie files with different timecode and without any in RV with and without Live Review on MacOS.
Add a list of changes, and note any that might need special attention during the review.