deps: Raise dependencies: cmake 3.19, OIIO 2.5, LLVM 11 #1914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some last minute dependency adjustments before I cut a beta for OSL 1.14. * Raise CMake minimum to 3.19 (from 3.15). This is still very conservative -- 4 years old, even more lax than our usual "3 years back" rule. Raising to 3.18 matches OIIO 3.0, and compared to 3.15, it adds Cuda support as well as the `--debug-find` flag. Further raising to 3.19 -- which in 2025 seems prudent, even though it's beyond the version chosen by OIIO 6 months ago -- adds more helpful features, including presets, and Apple Silicon support. * Raise OpenImageIO to 2.5 (from 2.4). The current release is 3.0, FYI. * Bump LLVM minimum to 11.0 (from 9.0). This is a pretty conservative move, still gives several years of back support, but brings a little code simplification. I expect that next year's OSL will raise the LLVM minimum by several more versions. Signed-off-by: Larry Gritz <[email protected]>
brechtvl
reviewed
Jan 6, 2025
| #ifdef OSL_LLVM_NEW_PASS_MANAGER | ||
| # if OSL_LLVM_VERSION <= 110 | ||
| # error "New pass manager not supported in LLVM 11 and earlier" | ||
| # endif |
Contributor
There was a problem hiding this comment.
This can't be removed yet, since it's <= 11 and not < 11.
Collaborator
Author
There was a problem hiding this comment.
I'll revert that, but curiously, the "oldest everything" CI test passed using LLVM 11. That's because this doesn't technically matter -- we only turn on the new pass manager when LLVM version >= 16, and this check merely ensures that if it's on, we're using at least 11. So in a sense, it's redundant (other than to ensure that we don't change the logic about when we use the new pass manager to a version too early).
Collaborator
Author
There was a problem hiding this comment.
Good catch, by the way, thanks for looking carefully at this.
Signed-off-by: Larry Gritz <[email protected]>
brechtvl
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some last minute dependency adjustments before I cut a beta for OSL 1.14.
Raise CMake minimum to 3.19 (from 3.15). This is still very conservative -- 4 years old, even more lax than our usual "3 years back" rule.
Raising to 3.18 matches OIIO 3.0, and compared to 3.15, it adds Cuda support as well as the
--debug-findflag. Further raising to 3.19 -- which in 2025 seems prudent, even though it's beyond the version chosen by OIIO 6 months ago -- adds more helpful features, including presets, and Apple Silicon support.Raise OpenImageIO to 2.5 (from 2.4). The current release is 3.0, FYI.
Bump LLVM minimum to 11.0 (from 9.0). This is a pretty conservative move, still gives several years of back support, but brings a little code simplification. I expect that next year's OSL will raise the LLVM minimum by several more versions.