Share Shading Context when optimizing/jitting a shader… #1952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal context. No need for a 2nd set of heaps/buffers when the existing context can be reused. Reduces memory footprint which increases cache efficiency, especially for threaded usage. Signed-off-by: Alex M. Wells <[email protected]>
AlexMWells
changed the title
Signed-off-by: Alex M. Wells <[email protected]>
Contributor
Author
|
Hold up on this, going to update so that such that the work to "borrow" a shading context for opt/jit is internal to ShadingContext and not burden on its user to understand the implementation details. |
Collaborator
|
#1953 fixes the broken CI, which is not the fault of this PR. I merged it, so if you rebase on the current main, you should get a passing CI. |
…ingContext::restoreFromJit(const RestoreState &)" to reduce repeated code and make usage/intent more self documenting Signed-off-by: Alex M. Wells <[email protected]>
Signed-off-by: Alex M. Wells <[email protected]>
Contributor
Author
|
Ok Larry, this is ready for review |
lgritz
approved these changes
Jul 8, 2025
Collaborator
lgritz
left a comment
lgritz
left a comment
There was a problem hiding this comment.
Sorry for the delay, this slipped through the cracks. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… vs. grabbing an additi onal context.
Description
No need for a 2nd set of heaps/buffers when the existing context can be reused. Reduces memory footprint which increases cache efficiency, especially for threaded usage.
We can just swap the TexturePerThread info out for a null pointer and restore the previous one afterwards
For completeness we also process the errors in the context.
Tests
Existing tests exercise the changes.
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.