feat: Optional texture argument for colorspace (part 1 -- don't reject)#1966
Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:mainfrom Apr 5, 2025
Merged
Conversation
A while back, we proposed a new optional token/value parameter for the texture functions: "colorspace", followed by a color space name, which indicates that the texture name referenced is understood to be in that colorspace (this is passed to the TextureSystem, which has known for some time how to ensure the right transformations are applied as tile data is read in). We do not fully implement this yet! It's more involved than I have time to get right by the scheduled OSL 1.14 non-beta release (which was supposed to have been on Apr 1, oh no). Not wanting to delay things further, this change at least causes the use of the new parameter (which apparently, MaterialX has been using) to be silently accepted and ignored, rather than generating runtime errors. We'll come back right away for a more complete working implementation. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
@lkerley @jstone-lucasfilm This doesn't make it "work" in the sense of being fully functional, but it makes it safe to pass the parameter. As soon as this gets approved and merged, I will tag the non-beta and make 1.14 the new supported release family. |
Collaborator
Author
|
Would love a second pair of eyes on these, but I'm going to merge it by tomorrow either way if there are no specific objections, because the release is so hopelessly overdue. |
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Apr 5, 2025
…t) (AcademySoftwareFoundation#1966) Optional texture argument for colorspace (part 1 -- don't reject) A while back, we proposed a new optional token/value parameter for the texture functions: "colorspace", followed by a color space name, which indicates that the texture name referenced is understood to be in that colorspace (this is passed to the TextureSystem, which has known for some time how to ensure the right transformations are applied as tile data is read in). We do not fully implement this yet! It's more involved than I have time to get right by the scheduled OSL 1.14 non-beta release (which was supposed to have been on Apr 1, oh no). Not wanting to delay things further, this change at least causes the use of the new parameter (which apparently, MaterialX has been using) to be silently accepted and ignored, rather than generating runtime errors. We'll come back right away for a more complete working implementation. Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A while back, we proposed a new optional token/value parameter for the texture functions: "colorspace", followed by a color space name, which indicates that the texture name referenced is understood to be in that colorspace (this is passed to the TextureSystem, which has known for some time how to ensure the right transformations are applied as tile data is read in).
We do not fully implement this yet! It's more involved than I have time to get right by the scheduled OSL 1.14 non-beta release (which was supposed to have been on Apr 1, oh no). Not wanting to delay things further, this change at least causes the use of the new parameter (which apparently, MaterialX has been using) to be silently accepted and ignored, rather than generating runtime errors. We'll come back right away for a more complete working implementation.