deps: test against pybind11 3.0 and minor fixes #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pybind 3.0 to the CI test matrix. Found a place where we defined a python method wice, fixed that. Ran into some trouble where the Mac runners which used a pre-built OIIO supplied by Homebrew, and apparently compiled against pybind11 2.x. I think maybe there are some corner cases where if you have two python modules that share types (TypeDesc and a few more, in this case), they should not be built with pre-3.0 and post-3.0 versions of pybind11? The quick fix was to switch to having OSL CI on Mac just build an OIIO from scratch to ensure that it was using the same pybind11. But that identified yet another problem (which I also think is a runner issue) that required some minor adjustment to how OIIO auto-builds libpng. There is a patch in review on the OIIO side for this. But since that's not merged yet, I have doctored this PR to pull OIIO from my own fork, the branch containing the fix, just to show that it works. After the merge on the OIIO side, I will remove those customizations from here before this PR is merged. (And delete this paragraph.) Signed-off-by: Larry Gritz <[email protected]>
Signed-off-by: Larry Gritz <[email protected]>
Collaborator
Author
|
I will merge this change tomorrow unless there are objections -- it's needed to fix a CI break. |
Collaborator
Author
|
No objections -> merging to fix broken Mac CI. |
lgritz
merged commit d6e4979
into
AcademySoftwareFoundation:main
24 of 26 checks passed
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Jul 25, 2025
…ation#2007) Add pybind11 3.0 to the CI test matrix. Found a place where we defined a python method twice, fixed that. Ran into some trouble where the Mac runners which used a pre-built OIIO supplied by Homebrew, and apparently compiled against pybind11 2.x. I think maybe there are some corner cases where if you have two python modules that share types (TypeDesc and a few more, in this case), they should not be built with pre-3.0 and post-3.0 versions of pybind11? The quick fix was to switch to having OSL CI on Mac just build an OIIO from scratch to ensure that it was using the same pybind11. But that identified yet another problem (which I also think is a runner issue) that required some minor adjustment to how OIIO auto-builds libpng. There is a patch in review on the OIIO side for this. But since that's not merged yet, I have doctored this PR to pull OIIO from my own fork, the branch containing the fix, just to show that it works. After the merge on the OIIO side, I will remove those customizations from here before this PR is merged. (And delete this paragraph.) --------- Signed-off-by: Larry Gritz <[email protected]>
lgritz
added
the
build / testing / port / CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pybind11 3.0 to the CI test matrix.
Found a place where we defined a python method twice, fixed that.
Ran into some trouble where the Mac runners which used a pre-built OIIO supplied by Homebrew, and apparently compiled against pybind11 2.x. I think maybe there are some corner cases where if you have two python modules that share types (TypeDesc and a few more, in this case), they should not be built with pre-3.0 and post-3.0 versions of pybind11?
The quick fix was to switch to having OSL CI on Mac just build an OIIO from scratch to ensure that it was using the same pybind11. But that identified yet another problem (which I also think is a runner issue) that required some minor adjustment to how OIIO auto-builds libpng.