cleanup: Simplify some clauses involving old compilers #2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our minimum gcc 9 and clang 5 lets us simplify a few preprocessor conditionals. Also give more clear cmake messages when too-old compilers are encountered, for gcc, clang, and Apple clang. Define OSL_GCC_ONLY_PRAGMA, which is handy in the future. Signed-off-by: Larry Gritz <[email protected]>
Collaborator
Author
|
No comments for over a week? If there are no objections, I will merge in the relatively near future. |
Collaborator
Author
|
Any objections? |
bisqq
pushed a commit
to bisqq/OpenShadingLanguage
that referenced
this pull request
Sep 25, 2025
…reFoundation#2016) Our minimum gcc 9 and clang 5 lets us simplify a few preprocessor conditionals. Also give more clear cmake messages when too-old compilers are encountered, for gcc, clang, and Apple clang. Define OSL_GCC_ONLY_PRAGMA, which is handy in the future. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Alexandru Biscoveanu <[email protected]>
lgritz
added
the
build / testing / port / CI
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Oct 24, 2025
…reFoundation#2016) Our minimum gcc 9 and clang 5 lets us simplify a few preprocessor conditionals. Also give more clear cmake messages when too-old compilers are encountered, for gcc, clang, and Apple clang. Define OSL_GCC_ONLY_PRAGMA, which is handy in the future. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our minimum gcc 9 and clang 5 lets us simplify a few preprocessor conditionals.
Also give more clear cmake messages when too-old compilers are encountered, for gcc, clang, and Apple clang.