build(windows): Ensure 'lib' prefix is on the dynamicaly loaded batched shading libraries for windows #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Alex Fuller <[email protected]>
boberfly
force-pushed
the
win_batched_prefix_fix
branch
from
d060e83 to
0e5d986
Compare
Collaborator
|
As a note, that test failure is happening in main, it's not related to your PR. I'm fixing it separately. |
Collaborator
|
@AlexMWells This look ok from your perspective? |
lgritz
added
build / testing / port / CI
lgritz
approved these changes
Oct 15, 2025
Collaborator
lgritz
left a comment
lgritz
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix
lgritz
changed the title
lgritz
merged commit 9da2d79
into
AcademySoftwareFoundation:main
25 of 26 checks passed
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Oct 25, 2025
…ed shading libraries for windows (AcademySoftwareFoundation#2025) When the ISA-specific dll is loaded dynamically by the batched shading system, it was expecting the lib prefix to be there. Signed-off-by: Alex Fuller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building Gaffer and running its unit-tests, the OSL batched build of windows couldn't find the .dll's as windows tends to omit the lib prefix from its libraries - this ensures it is applied.
Tests
I'm not too sure on that if batched mode is tested on windows yet?
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.