ci: Adjust comparison threshold for render-microfacet test #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something must have changed on the GHA runners? Or a compiler version? On one test job, we started failing this one test, the noise pattern changed a few days ago, independently of any change to OSL repo. Bumping up the comparison thresholds slightly appears to do the trick. Signed-off-by: Larry Gritz <[email protected]>
Collaborator
Author
|
This is still going to fail one test until #2028 is also merged. |
lgritz
added
the
build / testing / port / CI
Collaborator
Author
|
Merging to fix broken CI. |
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Oct 24, 2025
…ftwareFoundation#2027) Something must have changed on the GHA runners? Or a compiler version? On one test job, we started failing this one test, the noise pattern changed a few days ago, independently of any change to OSL repo. Bumping up the comparison thresholds slightly appears to do the trick. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something must have changed on the GHA runners? Or a compiler version? On one test job, we started failing this one test, the noise pattern changed a few days ago, independently of any change to OSL repo.
Bumping up the comparison thresholds slightly appears to do the trick.