-
Notifications
You must be signed in to change notification settings - Fork 307
Remove vfx platform 2020 support from README.md, add 2024 and 2025, note that 3.12 is also supported #1883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vfx platform 2020 support from README.md, add 2024 and 2025, note that 3.12 is also supported #1883
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
+ Coverage 84.11% 84.72% +0.61%
==========================================
Files 198 177 -21
Lines 22241 12809 -9432
Branches 4687 1191 -3496
==========================================
- Hits 18709 10853 -7856
+ Misses 2610 1773 -837
+ Partials 922 183 -739
Flags with carried forward coverage won't be shown. Click here to find out more. see 135 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Stephan, current vfxplatform year is 2025, we currently claim to support 2023,22,21. Actually it should be cy+3 which means 25,24,23,22. So we should remove 2021 as well. Accordingly this also gives us a bump to python 3.9 so we can at long last drop python 3.7 support.
Added changes in to remove 3.7 and 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. The only thing that I would add is a mention that we also support 3.12 since we already ship wheels for 3.12 and according to https://clickpy.clickhouse.com/dashboard/opentimelineio?min_date=2024-03-03&max_date=2025-04-20, users effectively depend on 3.12.
Also, a nice side effect of this PR is that it will enable #1816.
@JeanChristopheMorinPerso to be clear, does this PR also address #1094 ? |
Co-authored-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Stephan Steinbach <[email protected]>
@ssteinbach I don't think it does. We aren't really testing against the VFX platform targets like we should, at least on Linux. Doing so would require us to run the tests in docker containers that match the platform years. |
Ok got it. I'll leave that issue off this pr, that's a different project. |
@ssteinbach I might be interpreting your comment wrong, but I don't see a note about python 3.12, is this expected? |
@JeanChristopheMorinPerso yup! Forgot to push a commit. That is there now too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #1876
Fixes #1804
As noted in the comments below by @JeanChristopheMorinPerso, this PR doesn't fully cover #1094, it doesn't add any of the VFX platform container related testing stuff.