Single pass Forward TX for AVX optimization#101
Merged
Conversation
Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com>
Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com>
Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com>
Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com>
Collaborator
Author
|
Added a commit to ensure ARM_NEON compatibility |
kpchoi
reviewed
Jun 7, 2025
src/oapv.c
Outdated
| ctx->fn_itx = oapv_tbl_fn_itx; | ||
| ctx->fn_itx_adj = oapv_tbl_fn_itx_adj; | ||
| ctx->fn_txb = oapv_tbl_fn_tx; | ||
| ctx->fn_txb_part = oapv_tbl_fn_tx_part; |
Collaborator
There was a problem hiding this comment.
ctx->fn_txb_part doesn't seem to be called anywhere.
Is this required?
Collaborator
Author
There was a problem hiding this comment.
Removed it in the latest commit.
src/avx/oapv_tq_avx.c
Outdated
Comment on lines
98
to
103
| const oapv_fn_tx_part_t oapv_tbl_fn_txb_part_avx[2] = | ||
| { | ||
| oapv_tx_part_avx, | ||
| NULL | ||
| }; | ||
|
|
Collaborator
There was a problem hiding this comment.
I don't know whether this structure is actually used.
fn_tx_part_t variable is not called anwhere...
Collaborator
Author
There was a problem hiding this comment.
Yes it is unused. Thus removing it.
Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com>
alejandro-arango-epicgames
pushed a commit
to alejandro-arango-epicgames/openapv
that referenced
this pull request
Sep 29, 2025
…n#101) * function pointer updates Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * single pass Fwd Tx C-code update Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * single pass Fwd Tx AVX-code update Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * single pass Fwd Tx ARM_Neon-code update Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * remove unused code Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> --------- Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two-pass forward TX is optimized into single-pass by merging 2 passes in AVX. The merging is done in a similar way as that of earlier inverse TX optimization. Encoder profiling on test sequences shows an average ~3% speed-up on Linux platform under single and multi (up to 4) threading scenario.