Closed
Conversation
Collaborator
subhrajitm20
commented
Jul 8, 2025
subhrajitm20
commented
- Debug oapv_memset_x128_avx() code. Added missing iterator.
- Pointed oapv_mset_x64a to oapv_memset_x128_avx() as a temporary speed-up measure.
* incremented ptr while storing value_vector Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com>
Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com>
kpchoi
reviewed
Jul 9, 2025
| #define oapv_mset_x64a(dst, v, size) memset((dst), (v), (size)) | ||
| #if X86_SSE | ||
| #define oapv_mset_x128(dst, v, size) oapv_memset_x128_avx((dst), (v), (size)) | ||
| #define oapv_mset_x64a(dst, v, size) oapv_memset_x128_avx((dst), (v), (size)) |
Collaborator
There was a problem hiding this comment.
oapv_mset_x64a() doesn't guranttee 128byte-aligned size.
The AVX optimized oapv_mset_x128 doesn't seems to handle the unalinged size case.
Collaborator
Author
|
Relevant changes from this PR have been added to main by @kpchoi. Thus, Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.