feat: add macos arm64 build #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rene Leonhardt <[email protected]>
reneleonhardt
force-pushed
the
feat/add-macos-arm64-build
branch
from
9b2e311 to
714d4b6
Compare
Collaborator
|
@dariusz-f |
sidwat
reviewed
Sep 19, 2025
| cmake --build build-windows | ||
| ``` | ||
|
|
||
| - Build Instructions macOS (Apple Silicon) |
Collaborator
There was a problem hiding this comment.
The following build commands can also be added :-
- macOS universal build :
cmake -S . -B build -DCMAKE_TOOLCHAIN_FILE=macos_universal_toolchain.cmake -DUNIVERSAL=1 -DCMAKE_BUILD_TYPE=Release
cmake --build build
- ios arm64 build :-
cmake -S . -B build -DCMAKE_TOOLCHAIN_FILE=ios_arm64_toolchain.cmake -DCMAKE_BUILD_TYPE=Release
cmake --build build
Contributor
Author
There was a problem hiding this comment.
Thank you, done.
Signed-off-by: Rene Leonhardt <[email protected]>
dariusz-f
requested changes
Sep 19, 2025
| cmake -S ${{github.workspace}} -B ${{github.workspace}}/build-darwin -DUNIVERSAL=FALSE -DCMAKE_OSX_ARCHITECTURES=arm64 -DARM=1 -DCMAKE_BUILD_TYPE=Release | ||
| cmake --build ${{github.workspace}}/build-darwin | ||
| cd ${{github.workspace}}/build-darwin | ||
| # Builds OpenAPV-0.2.0.3-Darwin.tar.gz |
Collaborator
There was a problem hiding this comment.
Remove that comment with hardcoded version
| cmake -S ${{github.workspace}} -B ${{github.workspace}}/build -DCMAKE_TOOLCHAIN_FILE=macos_universal_toolchain.cmake -DUNIVERSAL=1 -DCMAKE_BUILD_TYPE=Release | ||
| cmake --build ${{github.workspace}}/build | ||
| cd ${{github.workspace}}/build | ||
| # Builds OpenAPV-0.2.0.3-Darwin.dmg |
Collaborator
There was a problem hiding this comment.
Remove that comment with hardcoded version
Signed-off-by: Rene Leonhardt <[email protected]>
dariusz-f
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features