CMake: misc. build fixes for older toolchains#181
Open
robUx4 wants to merge 5 commits intoAcademySoftwareFoundation:mainfrom
Open
CMake: misc. build fixes for older toolchains#181robUx4 wants to merge 5 commits intoAcademySoftwareFoundation:mainfrom
robUx4 wants to merge 5 commits intoAcademySoftwareFoundation:mainfrom
Conversation
robUx4
changed the title
robUx4
force-pushed
the
misc-cmake
branch
3 times, most recently
from
24df7e0 to
5524000
Compare
Anemptyship
reviewed
Jan 15, 2026
It's set by all Windows compilers, including x86_64 and arm64. Otherwise pthread.h is included instead of windows.h/process.h in oapv_tpool.c. Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
It can generate some warnings or compilations errors. The official CMake way of picking the thread library [^1] should probably be used for non-Windows targets. [^1]: https://cmake.org/cmake/help/latest/module/FindThreads.html Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
Some older AVX2 compilers don't have it, but it's possible to use a macro instead [^1]. [^1]: https://stackoverflow.com/a/32630658/1266123 Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
Author
|
I updated the commit that uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pthread.hwas included on Windows)_mm256_setr_m128i(). Some older AVX2 compilers don't have it, but it's possible to use a macro instead 1.Footnotes
https://stackoverflow.com/a/32630658/1266123 ↩