Merged
Conversation
Collaborator
kpchoi
commented
Apr 19, 2025
kpchoi
commented
- updated README file (changed screenshot of ImHex)
- fixed invalid encoder application operation in case of y4m input
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
subhrajitm20
pushed a commit
that referenced
this pull request
May 5, 2025
* updated imhex screenshot compatible with version 4 Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> * updated README Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> * fixed invalid operation incase of y4m input Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> --------- Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com>
cpncf
pushed a commit
that referenced
this pull request
May 6, 2025
* Error handling in encoder for width setting * For --input-csp 2, -w should be a multiple of 2 * move width check in encoder to check_conf() function * invalid configuration check of --input-csp 2 and -w non-multiple of 2 moved to the check_conf() function * Update readme (#67) * updated imhex screenshot compatible with version 4 Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> * updated README Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> * fixed invalid operation incase of y4m input Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> --------- Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * Error handling in encoder for width setting * For --input-csp 2, -w should be a multiple of 2 Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * move width check in encoder to check_conf() function * invalid configuration check of --input-csp 2 and -w non-multiple of 2 moved to the check_conf() function Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * Enclosing check code in for loop of max_num_frms * This will allow flexible implementation of multiple frames encoding in near future Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * Using existing for loop for handling invalid width Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * Bug fix: updating FRM_IDX to loop parameter Signed-off-by: Subhrajit Mishra <84323996+subhrajitm20@users.noreply.github.com> --------- Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> Signed-off-by: Subhrajit Mishra <84323996+subhrajitm20@users.noreply.github.com> Co-authored-by: kpchoi <kp5.choi@samsung.com>
alejandro-arango-epicgames
pushed a commit
to alejandro-arango-epicgames/openapv
that referenced
this pull request
Sep 29, 2025
* updated imhex screenshot compatible with version 4 Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> * updated README Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> * fixed invalid operation incase of y4m input Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> --------- Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
alejandro-arango-epicgames
pushed a commit
to alejandro-arango-epicgames/openapv
that referenced
this pull request
Sep 29, 2025
…n#69) * Error handling in encoder for width setting * For --input-csp 2, -w should be a multiple of 2 * move width check in encoder to check_conf() function * invalid configuration check of --input-csp 2 and -w non-multiple of 2 moved to the check_conf() function * Update readme (AcademySoftwareFoundation#67) * updated imhex screenshot compatible with version 4 Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> * updated README Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> * fixed invalid operation incase of y4m input Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> --------- Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * Error handling in encoder for width setting * For --input-csp 2, -w should be a multiple of 2 Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * move width check in encoder to check_conf() function * invalid configuration check of --input-csp 2 and -w non-multiple of 2 moved to the check_conf() function Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * Enclosing check code in for loop of max_num_frms * This will allow flexible implementation of multiple frames encoding in near future Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * Using existing for loop for handling invalid width Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> * Bug fix: updating FRM_IDX to loop parameter Signed-off-by: Subhrajit Mishra <84323996+subhrajitm20@users.noreply.github.com> --------- Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com> Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com> Signed-off-by: Subhrajit Mishra <84323996+subhrajitm20@users.noreply.github.com> Co-authored-by: kpchoi <kp5.choi@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.