Skip to content

feat! : output only raw bitstream format form encoder without size #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dariusz-f wants to merge 2 commits into from
Closed

feat! : output only raw bitstream format form encoder without size #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab8d1b3
feat! : output ony raw bistream format form encoder without size
dariusz-f Apr 30, 2025
c0e586e
fix: properly write bitstream size
dariusz-f Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/oapv_app_enc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,9 +856,17 @@ int main(int argc, const char **argv)
}
}

unsigned char bs_size[4];
oapv_bsw_write_direct(bs_size, stat.write, 32);
Copy link
Collaborator

@kpchoi kpchoi Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function cannot be called from application code.
Please let me know what you want first.


/* store bitstream */
if(OAPV_SUCCEEDED(ret)) {
if(is_out && stat.write > 0) {
if(write_data(args_var->fname_out, bs_size, 4)) {
logerr("cannot write bitstream\n");
ret = -1;
goto ERR;
}
if(write_data(args_var->fname_out, bs_buf, stat.write)) {
logerr("cannot write bitstream\n");
ret = -1;
Expand Down
5 changes: 0 additions & 5 deletions src/oapv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,10 +1303,8 @@ int oapve_encode(oapve_t eid, oapv_frms_t *ifrms, oapvm_t mid, oapv_bitb_t *bitb
oapv_bsw_init(bs, bitb->addr, bitb->bsize, NULL);
oapv_mset(stat, 0, sizeof(oapve_stat_t));

u8 *bs_pos_au_beg = oapv_bsw_sink(bs); // address syntax of au size
u8 *bs_pos_pbu_beg;
oapv_bs_t bs_pbu_beg;
oapv_bsw_write(bs, 0, 32); // raw bitstream byte size (skip)

oapv_bsw_write(bs, 0x61507631, 32); // signature ('aPv1')

Expand Down Expand Up @@ -1382,9 +1380,6 @@ int oapve_encode(oapve_t eid, oapv_frms_t *ifrms, oapvm_t mid, oapv_bitb_t *bitb
}
}

u32 au_size = (u32)((u8 *)oapv_bsw_sink(bs) - bs_pos_au_beg) - 4 /* au_size */;
oapv_bsw_write_direct(bs_pos_au_beg, au_size, 32); /* u(32) */

oapv_bsw_deinit(&ctx->bs); /* de-init BSW */
stat->write = bsw_get_write_byte(&ctx->bs);

Expand Down