Skip to content

Error handling in encoder for width setting #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpncf merged 9 commits into from
May 6, 2025
Merged

Error handling in encoder for width setting #69

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1cb084f
Error handling in encoder for width setting
subhrajitm20 May 2, 2025
1d431fe
move width check in encoder to check_conf() function
subhrajitm20 May 5, 2025
2563c8e
Update readme (#67)
kpchoi Apr 19, 2025
f215ec0
Error handling in encoder for width setting
subhrajitm20 May 2, 2025
c423758
move width check in encoder to check_conf() function
subhrajitm20 May 5, 2025
a289c7b
Merge branch 'handle_error_width_option' of https://github.com/Academ…
subhrajitm20 May 5, 2025
270260f
Enclosing check code in for loop of max_num_frms
subhrajitm20 May 5, 2025
d50daad
Using existing for loop for handling invalid width
subhrajitm20 May 5, 2025
263fc0b
Bug fix: updating FRM_IDX to loop parameter
subhrajitm20 May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/oapv_app_enc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,11 @@ static void print_usage(const char **argv)

static int check_conf(oapve_cdesc_t *cdesc, args_var_t *vars)
{
// ensure frame width multiple of 2 in case of 422 format
if ((vars->input_csp == 2) && (cdesc->param[FRM_IDX].w & 0x1)) {
logerr("width should be a multiple of 2 for '--input-csp 2'\n");
return -1;
}
Copy link
Collaborator

@kpchoi kpchoi May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch is correct, but I'd like to recommend to use for loop with cdesc.max_num_frms.
Even though the cdesc.max_num_frms value is alwasy 1, the loop with cdesc.max_num_frms value would be much more flexible when we start to support multiple frames encoding in near future.

like this;

for (i < cdesc.max_num_frms) {
if ((vars->input_csp == 2) && (cdesc->param[i].w & 0x1)) {
logerr("%d-th frame's width should be a multiple of 2 for '--input-csp 2'\n", i);
return -1;
}
}

Copy link
Collaborator Author

@subhrajitm20 subhrajitm20 May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the changes inside for loop to support multiple frames encoding

int i;
for(i = 0; i < cdesc->max_num_frms; i++) {
if(vars->hash && strlen(vars->fname_rec) == 0) {
Expand Down