Set correct macro for static symbols#77
Merged
kpchoi merged 2 commits intoAcademySoftwareFoundation:mainfrom May 9, 2025
Merged
Set correct macro for static symbols#77kpchoi merged 2 commits intoAcademySoftwareFoundation:mainfrom
kpchoi merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: BtbN <timo@rothenpieler.org>
LIB_NAME was not defined, variable is named LIB_NAME_BASE. Signed-off-by: BtbN <timo@rothenpieler.org>
alejandro-arango-epicgames
pushed a commit
to alejandro-arango-epicgames/openapv
that referenced
this pull request
Sep 29, 2025
* Set correct macro for static symbols Signed-off-by: BtbN <timo@rothenpieler.org> * Improve oapv.pc for static linking LIB_NAME was not defined, variable is named LIB_NAME_BASE. Signed-off-by: BtbN <timo@rothenpieler.org> --------- Signed-off-by: BtbN <timo@rothenpieler.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if I interpreted this correctly, but LIBSHARED_AND_STATIC_STATIC_DEFINE does not appear anywhere else in the codebase, but OAPV_STATIC_DEFINE is used instead.
This flag also needs to be set in the pkgconfig file for private Cflags. Plus, the static library is installed into a subdir of the libdir, so that needs to be set in there, too.