Skip to content

Skip y4m test on non-seekable input#79

Closed
fhvwy wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
fhvwy:non-seekable-input
Closed

Skip y4m test on non-seekable input#79
fhvwy wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
fhvwy:non-seekable-input

Conversation

@fhvwy
Copy link
Contributor

@fhvwy fhvwy commented May 7, 2025

On a non-seekable input such as a pipe this check skips the first eight bytes which silently corrupts the stream.

This fixes the use-case of piping input from another program because some preprocessing or conversion is needed, such as with ffmpeg:

 ffmpeg -i input.mp4 -vf scale=1280:720,format=yuv422p10 -f rawvideo - | bin/oapv_app_enc -i /dev/stdin -w 1280 -h 720 --input-csp 2 -d 10 -z 60 --profile 422-10 --band 3 -o out.apv

@kpchoi kpchoi requested a review from tuzm24 May 7, 2025 23:36
@tuzm24
Copy link
Collaborator

tuzm24 commented May 8, 2025

On a non-seekable input such as a pipe this check skips the first eight bytes which silently corrupts the stream.

Signed-off-by: Mark Thompson <sw@jkqxz.net>
@fhvwy fhvwy closed this May 8, 2025
@fhvwy fhvwy force-pushed the non-seekable-input branch from f685090 to a53dd2e Compare May 8, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants