-
Notifications
You must be signed in to change notification settings - Fork 663
extend exrmetrics #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend exrmetrics #1968
Conversation
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
|
@peterhillman these changes largely look fine to me, I did just have to rebase my PR against current main to get the CI to go through... [edit: I take it back, the rebase didn't actually fix the issue .... grrrrrr] |
meshula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks very helpful.
|
Yes, the fuzz test failure is because of the deprecated @peterhillman, we should add a description to |
f7a6cb4
into
AcademySoftwareFoundation:main
|
That's impressive that you made the json output by hand! |
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Adds better support for benchmarking to exrmetrics, including features from #1956:
exrmetrics /path/to/testimages/*.exrThe JSON output code is a little messy because it avoids adding a library dependency. It's possible certain outputs are invalid JSON due to missing commas or badly escaped strings, but the python test does try to parse the output.
Note this changes the JSON format of the output. Also, now requires
-ofor output file, since multiple input files are supported. Any old scripts callingexrmetrics inputfile outputfilewill now not overwrite outputfile. If outputfile already exists, it will be treated as an input and analyzed, otherwise an error will be reported. The new syntax isexrmetrics inputfile -o outputfile