Skip to content

Conversation

@palemieux
Copy link
Contributor

Replace my OpenJPH feature branch with OpenJPH 0.21.0

@cary-ilm
Copy link
Member

cary-ilm commented Feb 9, 2025

@palemieux and/or @peterhillman, any idea why the fuzzing workflow fails? It appears to be failing to link with undefined references to openjph and add odd error just before:

/usr/bin/ld: /usr/bin/ld: DWARF error: invalid or unhandled FORM value: 0x25

Does the fuzzer link line need to be updated?

Now that I think about, I believe this workflow was failing on the PR prior to merge, but I assumed it was because of other issues.

Also, @peterhillman, do we need to update something to get the fuzzer to run on the htj2k-beta branch? Presumably, it should.

@palemieux
Copy link
Contributor Author

The OpenJPH library might be missing from the oss-fuzz build file for OpenEXR at https://github.com/google/oss-fuzz/blob/bfa03c999c5bc5e69e28d656531a8f5705eb2730/projects/openexr/build.sh#L24 ?

Who has been handling oss-fuzz within the OpenEXR community. I can work with them to fix oss-fuzz.

@cary-ilm
Copy link
Member

cary-ilm commented Feb 9, 2025

We'll resolve the fuzz failure separately, unrelated to this.

@cary-ilm cary-ilm merged commit 813c7cb into AcademySoftwareFoundation:htj2k-beta Feb 9, 2025
31 of 33 checks passed
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request May 5, 2025
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request May 14, 2025
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request May 17, 2025
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request May 17, 2025
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request May 17, 2025
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request May 19, 2025
cary-ilm added a commit that referenced this pull request May 23, 2025
* Add HTJ2K Compressor (#1883)

* Add HT256 compressor

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

* Update src/lib/OpenEXR/ImfCompression.h

Co-authored-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

* Update src/lib/OpenEXR/ImfCompression.cpp

Co-authored-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

* Update website/ReadingAndWritingImageFiles.rst

Co-authored-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

* Add channel map

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

---------

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Co-authored-by: Cary Phillips <cary@ilm.com>

* Bump OpenJPH (#1978)

* Bump OpenJPH to 0.21.2 (#1994)

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

* Rebase htj2k-beta onto main (#2033)

Signed-off-by: Cary Phillips <cary@ilm.com>

* Improve RGB channel detection heuristics for the HT256 encoder (#2029)

* Allow lowercase r,g and b, and reg, greee and blue.

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

* Improved RGB channel detection heuristics

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

* Fix Windows build

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

* Improve RGB heuristics
Add unit tests

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

* Removed unusued color channel abbreviations

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

---------

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>

* Fix HTJ2K Compressor python (#2038)

* HT256 COMPRESSION

Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>

* HT256 Compression fix

Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>

---------

Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>

* resolve conflicts

Signed-off-by: Cary Phillips <cary@ilm.com>

* OPENEXR_FORCE_INTERNAL_OPENJPH in pyproject.toml

Signed-off-by: Cary Phillips <cary@ilm.com>

* POSITION_INDEPENDENT_CODE=ON for openjpg and OpenEXR.so

Signed-off-by: Cary Phillips <cary@ilm.com>

* CMAKE_VERBOSE_MAKEFILE=ON

Signed-off-by: Cary Phillips <cary@ilm.com>

* Disable macos universal2 cibuildwheel, doesn't work with openjph

Signed-off-by: Cary Phillips <cary@ilm.com>

* add openjph to OpenEXR.pc

Signed-off-by: Cary Phillips <cary@ilm.com>

* using ubuntu-latest for website.yml

Signed-off-by: Cary Phillips <cary@ilm.com>

* website.1

Signed-off-by: Cary Phillips <cary@ilm.com>

---------

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>
Co-authored-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Co-authored-by: Todica Ionut <todicaionut2000111@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants