Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 29, 2025

Bumps openjph from 0.25.3 to 0.26.0.

Release notes

Sourced from openjph's releases.

0.26.0

This version:

  1. Renames src/core/common to src/core/openjph, as request by @​cary-ilm. It is best to use his words " OpenJPH headers are included in application code via #include <openjph/ojph_version.h>. The headers are expected to be in a folder named "openjph". The cmake configuration places them there in the installation step.

However, if OpenJPH is incorporated into an application via cmake's add_subdirectory, there is no installation step, the headers are included directly out of the source tree. There is no "openjph" folder, leading the #include <openjph/ojph_version.h> to fail.

Renaming the "common" directory to "openjph" resolves the build issue, since the headers then live inside the source tree in a directory with same name as the installation. The use of the "common" directory name is entirely internal to the OpenJPH build, it has no impact on the installation. The name should be arbitrary, so there should be no downside to renaming it this way."

  1. Modifies error message names. This may break your code. The modified versions are more descriptive, and less likely to be caught in a preprocessor macro.

  2. Address an issue identified by @​clshortfuse. Thank you Carlos. During compilation on windows using clang-cl, the compiler may received flags designed for clang or gcc.

What's Changed

Full Changelog: aous72/OpenJPH@0.25.3...0.26.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [openjph](https://github.com/aous72/OpenJPH) from 0.25.3 to 0.26.0.
- [Release notes](https://github.com/aous72/OpenJPH/releases)
- [Commits](aous72/OpenJPH@0.25.3...0.26.0)

---
updated-dependencies:
- dependency-name: openjph
  dependency-version: 0.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added bazel Pull requests that update bazel code dependencies Pull requests that update a dependency file labels Dec 29, 2025
@Vertexwahn
Copy link
Contributor

Vertexwahn commented Dec 29, 2025

I suggest closing this PR - src/core/common were moved to src/core/openjph - also includes at OpenEXR side need to be adapted - once this is done for OpenEXR we can also bump the OpenJPH version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bazel Pull requests that update bazel code dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants