Conversation
Signed-off-by: Gary Oberbrunner <garyo@darkstarsystems.com>
barretpj
reviewed
Nov 14, 2025
barretpj
reviewed
Nov 14, 2025
barretpj
reviewed
Nov 14, 2025
barretpj
reviewed
Nov 14, 2025
Signed-off-by: Gary Oberbrunner <garyo@darkstarsystems.com>
Contributor
Author
|
Thanks for the comments, Phil! I addressed them above. I deliberately left the 1.6 section above, to serve as a place to collect things that will go into 1.6 (that's how we usually do it, though I agree it can be confusing—suggestions appreciated! I moved the SpatialAwareness prop into 1.5.1, which is why it looked like it was getting deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs to go out soon so I can update the Conancenter repo with Windows fixes (see also #224 , and please review that as well so I can merge it), and check out conan-io/conan-center-index#26667 if you're interested in why the Windows stuff matters in the conanfile.