Make src/rawtoaces_core/ be covered 100% #235
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 85.70% 87.47% +1.76%
==========================================
Files 11 11
Lines 2197 2196 -1
Branches 331 331
==========================================
+ Hits 1883 1921 +38
+ Misses 314 275 -39
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
soswow
changed the title
|
And rest of them in core now done too |
| assert( sumVector( out_camera_XYZ_white_point ) != 0 ); | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
perhaps that line is unreachable because of the return, can we try removing it?
| add_executable ( | ||
| Test_DNGIdt | ||
| testDNGIdt.cpp | ||
| test_utils.cpp |
There was a problem hiding this comment.
Not entirely happy with exposing the rawtoaces_util code in the rawtoaces_core tests as an implicit dependency.
Hopefully we'll redo the logging soon, so the stderr capturing won't be needed anymore.
There was a problem hiding this comment.
hopefully I got what you mean and did what asked.
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
antond-weta
force-pushed
the
more-tests-5
branch
from
0f58a3a to
8fbf555
Compare
3 participants
Couple tests for
src/rawtoaces_core/rawtoaces_core.cpplines 706-738Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.