Various improvments to zsh shell plugin#1865
Various improvments to zsh shell plugin#1865maxnbk merged 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
=======================================
Coverage 59.31% 59.31%
=======================================
Files 126 126
Lines 17219 17219
Branches 3017 3017
=======================================
Hits 10213 10213
Misses 6322 6322
Partials 684 684 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @mmdanggg2, I think I would like to get this merged and released before the next release. But before merging it, I'd like to see why our tests didn't catch this problem before. See https://github.com/AcademySoftwareFoundation/rez/blob/main/src/rez/tests/test_shells.py#L255-L265. Because the shell code is quite 🍝 and complex, I'd really like to either fix the tests that didn't detect this problem or add a new test to make sure we can detect regressions in the future. Let me know if you need help with these tests. They can be very picky at times. |
Signed-off-by: James Horsley <jbhorsley@gmail.com>
Fixes the shell not starting when using
rez-env --norcThe originally used
--rcszsh argument does not specify an rc file as it does in bash, it simply enables reading rc files from$ZDOTDIRor$HOME. This was causing zsh to execute the rc file and exit.Fixes broken shell prompt