Skip to content

Various improvments to zsh shell plugin#1865

Merged
maxnbk merged 1 commit intoAcademySoftwareFoundation:mainfrom
mmdanggg2:main
May 15, 2025
Merged

Various improvments to zsh shell plugin#1865
maxnbk merged 1 commit intoAcademySoftwareFoundation:mainfrom
mmdanggg2:main

Conversation

@mmdanggg2
Copy link
Contributor

Fixes the shell not starting when using rez-env --norc
The originally used --rcs zsh argument does not specify an rc file as it does in bash, it simply enables reading rc files from $ZDOTDIR or $HOME. This was causing zsh to execute the rc file and exit.

Fixes broken shell prompt

@mmdanggg2 mmdanggg2 requested a review from a team as a code owner October 28, 2024 11:13
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mmdanggg2 / name: James Horsley (284fdee)

@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.31%. Comparing base (685a5d3) to head (284fdee).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1865   +/-   ##
=======================================
  Coverage   59.31%   59.31%           
=======================================
  Files         126      126           
  Lines       17219    17219           
  Branches     3017     3017           
=======================================
  Hits        10213    10213           
  Misses       6322     6322           
  Partials      684      684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeanChristopheMorinPerso
Copy link
Member

Hi @mmdanggg2, I think I would like to get this merged and released before the next release. But before merging it, I'd like to see why our tests didn't catch this problem before. See https://github.com/AcademySoftwareFoundation/rez/blob/main/src/rez/tests/test_shells.py#L255-L265. Because the shell code is quite 🍝 and complex, I'd really like to either fix the tests that didn't detect this problem or add a new test to make sure we can detect regressions in the future.

Let me know if you need help with these tests. They can be very picky at times.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Jan 26, 2025
@maxnbk maxnbk self-requested a review May 15, 2025 15:23
Signed-off-by: James Horsley <jbhorsley@gmail.com>
@maxnbk maxnbk merged commit 39c6ae6 into AcademySoftwareFoundation:main May 15, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants